Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 722343006: Add RenderSVGBlock::mapRectToPaintInvalidationBacking (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Add RenderSVGBlock::mapRectToPaintInvalidationBacking The two subclasses of RenderSVGBlock - RenderSVGForeignObject and RenderSVGText - have identical implementations (overrides) of the mapRectToPaintInvalidationBacking method (modulo a minor difference in how they call computeFloatRectForPaintInvalidation). Move the RenderSVGText implementation to RenderSVGBlock. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M Source/core/rendering/svg/RenderSVGBlock.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 1 month ago (2014-11-19 17:13:19 UTC) #2
f(malita)
lgtm
6 years, 1 month ago (2014-11-19 17:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722343006/1
6 years, 1 month ago (2014-11-19 17:22:45 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 20:18:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185618

Powered by Google App Engine
This is Rietveld 408576698