chrome/browser/extensions/api/dial/dial_service.cc - Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc ('K') | « chrome/browser/extensions/api/cast_streaming/performance_test.cc ('k') | cloud_print/gcp20/prototype/dns_sd_server.h » ('j') | cloud_print/gcp20/prototype/dns_sd_server.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/dial/dial_service.cc

diff --git a/chrome/browser/extensions/api/dial/dial_service.cc b/chrome/browser/extensions/api/dial/dial_service.cc

index b9c100540753cb10ba1b52da7878d4ff6e24ced7..fb348063c445194ffab39efe6026efaf00e8377d 100644

--- a/chrome/browser/extensions/api/dial/dial_service.cc

+++ b/chrome/browser/extensions/api/dial/dial_service.cc

@@ -172,13 +172,16 @@ bool DialServiceImpl::DialSocket::CreateAndBindSocket(

rand_cb,

net_log,

net_log_source));

- socket_->AllowBroadcast();

// 0 means bind a random port

net::IPEndPoint address(bind_ip_address, 0);

- if (!CheckResult("Bind", socket_->Bind(address)))

+ if (socket_->Open(address.GetFamily()) != net::OK ||

+ socket_->SetBroadcast(true) != net::OK ||

+ !CheckResult("Bind", socket_->Bind(address))) {

+ socket_.reset();

return false;

+ }

DCHECK(socket_.get());