cloud_print/gcp20/prototype/dns_sd_server.h - Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/dns_sd_server.h

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/dial/dial_service.cc ('K') | « chrome/browser/extensions/api/dial/dial_service.cc ('k') | cloud_print/gcp20/prototype/dns_sd_server.cc » ('j') | net/udp/udp_socket_libevent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cloud_print/gcp20/prototype/dns_sd_server.h

diff --git a/cloud_print/gcp20/prototype/dns_sd_server.h b/cloud_print/gcp20/prototype/dns_sd_server.h

index f9aa540d737353f5bb77b141161667c84b6fc778..dc8683fc0a3d12a09bf185cdb17f11819536fe72 100644

--- a/cloud_print/gcp20/prototype/dns_sd_server.h

+++ b/cloud_print/gcp20/prototype/dns_sd_server.h

@@ -13,7 +13,7 @@

#include "base/memory/weak_ptr.h"

#include "cloud_print/gcp20/prototype/service_parameters.h"

#include "net/base/ip_endpoint.h"

-#include "net/udp/udp_socket.h"

+#include "net/udp/udp_server_socket.h"

rvargas (doing something else) 2014/12/02 23:28:09 same question (etc)

hidehiko 2014/12/03 17:33:27 Acknowledged.

namespace net {

@@ -79,7 +79,7 @@ class DnsSdServer : public base::SupportsWeakPtr<DnsSdServer> {

uint32 GetCurrentTLL() const;

// Stores socket to multicast address.

- scoped_ptr<net::UDPSocket> socket_;

+ scoped_ptr<net::UDPServerSocket> socket_;

// Stores multicast address end point.

net::IPEndPoint multicast_address_;

@@ -106,4 +106,3 @@ class DnsSdServer : public base::SupportsWeakPtr<DnsSdServer> {

};

#endif // CLOUD_PRINT_GCP20_PROTOTYPE_DNS_SD_SERVER_H_