Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

Index: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
diff --git a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
index 6b27078298ce4b09efbe47cdb3ba76bf0f73f3c7..21d88285de5c09930875b192bfba0e819647ed01 100644
--- a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
+++ b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
@@ -28,7 +28,7 @@
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "net/base/rand_callback.h"
-#include "net/udp/udp_socket.h"
+#include "net/udp/udp_server_socket.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using media::cast::test::GetFreeLocalPort;
@@ -341,13 +341,10 @@ class CastStreamingApiTestWithPixelOutput : public CastStreamingApiTest {
 #define MAYBE_EndToEnd DISABLED_EndToEnd
 #endif
 IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, MAYBE_EndToEnd) {
-  scoped_ptr<net::UDPSocket> receive_socket(
-      new net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,
-                         net::RandIntCallback(),
-                         NULL,
-                         net::NetLog::Source()));
+  scoped_ptr<net::UDPServerSocket> receive_socket(

[rvargas (doing something else), 2014/12/02 23:28:09]

The class used here should come from the actual dependencies of this module. Are
you saying that the test was using the wrong layer before?

[hidehiko, 2014/12/03 17:33:27]

Without this CL, UDPServerSocket is just a subset of UDPSocket.
In this CL, I replace the UDPSocket with UDPServerSocket if possible,
because the UDPServerSocket keeps the current behavior, also, "possible" here
means that the socket is used as a server socket, so that should be fine.

Though I'd defer the decision to OWNERS of each directory.

[rvargas (doing something else), 2014/12/03 21:00:16]

To be honest, I completely forgot about UDPServerSocket/DatagramServerSocket
before seeing it here. Part of the question is why do we have two interfaces
that are so close yet slightly different. That doesn't have to be addressed by
this CL, but I don't think we (net) want to have to support both things :(. I
think we should remove one of them fairly soon (unless there are strong reasons
that I'm missing)

[hidehiko, 2014/12/04 04:03:36]

Ok, then let's address it separately. Maybe we want to keep UDPSocket, and get
rid of UDPServerSocket, IMHO.
As for PPAPI, which is my current focus, I talked about it with Bill, and I'm
planning to do it in a following CL.

+      new net::UDPServerSocket(NULL, net::NetLog::Source()));
   receive_socket->AllowAddressReuse();
-  ASSERT_EQ(net::OK, receive_socket->Bind(GetFreeLocalPort()));
+  ASSERT_EQ(net::OK, receive_socket->Listen(GetFreeLocalPort()));
   net::IPEndPoint receiver_end_point;
   ASSERT_EQ(net::OK, receive_socket->GetLocalAddress(&receiver_end_point));
   receive_socket.reset();