Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

chrome/browser/extensions/api/dial/dial_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/dial/dial_service.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 150 matching lines @@
 
 bool DialServiceImpl::DialSocket::CreateAndBindSocket(
     const IPAddressNumber& bind_ip_address,
     net::NetLog* net_log,
     net::NetLog::Source net_log_source) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!socket_.get());
   DCHECK(bind_ip_address.size() == net::kIPv4AddressSize);
 
   net::RandIntCallback rand_cb = base::Bind(&base::RandInt);
   socket_.reset(new UDPSocket(net::DatagramSocket::RANDOM_BIND,

[rvargas (doing something else), 2014/12/02 23:28:09]

this is the same code (extensions/api) so the dependencies should be the same.

[hidehiko, 2014/12/03 17:33:27]

Here, UDPSocket is kept to be used, because UDPServerSocket does not accept
RANDOM_BIND.

                               rand_cb,
                               net_log,
                               net_log_source));
-  socket_->AllowBroadcast();
 
   // 0 means bind a random port
   net::IPEndPoint address(bind_ip_address, 0);
 
-  if (!CheckResult("Bind", socket_->Bind(address)))
+  if (socket_->Open(address.GetFamily()) != net::OK ||
+      socket_->SetBroadcast(true) != net::OK ||
+      !CheckResult("Bind", socket_->Bind(address))) {
+    socket_.reset();
     return false;
+  }
 
   DCHECK(socket_.get());
 
   recv_buffer_ = new IOBufferWithSize(kDialRecvBufferSize);
   return ReadSocket();
 }
 
 void DialServiceImpl::DialSocket::SendOneRequest(
     const net::IPEndPoint& send_address,
     const scoped_refptr<net::StringIOBuffer>& send_buffer) {
@@ skipping 422 matching lines @@
   for (ScopedVector<DialSocket>::const_iterator iter = dial_sockets_.begin();
        iter != dial_sockets_.end();
        ++iter) {
     if (!((*iter)->IsClosed()))
       return true;
   }
   return false;
 }
 
 }  // namespace extensions