Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope This patch introduces the notificationclick and notificationerror events on the ServiceWorkerGlobalScope, and provides the necessary plumbing to be able to invoke them from the embedder. BUG=432527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185313

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments and test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -27 lines) Patch
M LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notification-event.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
A Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 1 chunk +14 lines, -4 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 5 chunks +30 lines, -8 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 1 chunk +11 lines, -5 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Peter Beverloo
+horo for Service Workers +mvanouwerkerk, mkwst for general review
6 years, 1 month ago (2014-11-12 16:44:10 UTC) #2
Peter Beverloo
This depends on https://codereview.chromium.org/718093002/.
6 years, 1 month ago (2014-11-12 16:44:22 UTC) #3
Michael van Ouwerkerk
lgtm https://codereview.chromium.org/720873002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h File Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h (right): https://codereview.chromium.org/720873002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h#newcode67 Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h:67: virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) = 0; Are ...
6 years, 1 month ago (2014-11-12 18:12:46 UTC) #4
horo
lgtm https://codereview.chromium.org/720873002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h File Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h (right): https://codereview.chromium.org/720873002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h#newcode67 Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h:67: virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) = 0; On ...
6 years, 1 month ago (2014-11-13 03:48:49 UTC) #5
Mike West
lgtm as well, sorry for the delay.
6 years, 1 month ago (2014-11-13 09:29:08 UTC) #6
Peter Beverloo
All done, thanks! I'll put this on the commit queue as soon as https://codereview.chromium.org/718093002/ lands ...
6 years, 1 month ago (2014-11-13 14:40:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720873002/20001
6 years, 1 month ago (2014-11-13 15:27:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36349)
6 years, 1 month ago (2014-11-13 17:28:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720873002/20001
6 years, 1 month ago (2014-11-13 17:35:34 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 19:44:17 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185313

Powered by Google App Engine
This is Rietveld 408576698