Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: comments and test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index cfb7add05c7a726565b858d6852768bb1fd0a016..653faff864b5e28b1d75121579ca5f4e099105cf 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -111,17 +111,23 @@ public:
// ServiceWorker specific method.
virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult result) { }
- // ServiceWorker specific method. Called after InstallEvent (dispatched
- // via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
- // script context.
- virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult result) { }
-
// ServiceWorker specific methods. Called after FetchEvent is handled by the
// ServiceWorker's script context. When no response is provided, the browser
// should fallback to native fetch.
virtual void didHandleFetchEvent(int fetchEventID) { }
virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse& response) { }
+ // ServiceWorker specific method. Called after InstallEvent (dispatched
+ // via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
+ // script context.
+ virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult result) { }
+
+ // ServiceWorker specific method. Called after NotificationClickEvent and
+ // NotificationErrorEvent (dispatched via WebServiceWorkerContextProxy) are
+ // handled by the ServiceWorker's script context.
+ virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleNotificationErrorEvent(int eventID, WebServiceWorkerEventResult result) { }
+
// ServiceWorker specific method. Called after PushEvent (dispatched via
// WebServiceWorkerContextProxy) is handled by the ServiceWorker's script
// context.
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698