Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: comments and test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 1f4d3b3406b0ba25535038805162b6fd24a433d1..a38b0eaa4239088f90b42e7e4c05ba8d6ccd76db 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -52,9 +52,11 @@ public:

virtual WebServiceWorkerCacheStorage* cacheStorage() const override;

virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) override;

- virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;

virtual void didHandleFetchEvent(int fetchEventID) override;

virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) override;

+ virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;

+ virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) override;

+ virtual void didHandleNotificationErrorEvent(int eventID, WebServiceWorkerEventResult) override;

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;

virtual void didHandleSyncEvent(int syncEventID) override;

virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

« no previous file with comments | « Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »