Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl - Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

Issue 720873002: Expose the notificationclick and notificationerror events on ServiceWorkerGlobalScope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: comments and test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.h ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

diff --git a/Source/modules/notifications/NotificationEvent.idl b/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

similarity index 54%

copy from Source/modules/notifications/NotificationEvent.idl

copy to Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

index b089670e6e811fdb6fbba7a0eee7c132989691e7..b2a61e5dbf84558ee4342060c0b1121f1476d710 100644

--- a/Source/modules/notifications/NotificationEvent.idl

+++ b/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

@@ -4,11 +4,9 @@

// https://notifications.spec.whatwg.org/#service-worker-api

-// FIXME: NotificationEvent should support being constructed from JavaScript.

[

- Exposed=ServiceWorker,

RuntimeEnabled=ServiceWorkerNotifications,

- TypeChecking=Interface,

-] interface NotificationEvent : ExtendableEvent {

- readonly attribute Notification notification;

+] partial interface ServiceWorkerGlobalScope {

+ attribute EventHandler onnotificationclick;

+ attribute EventHandler onnotificationerror;

};