Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 720633003: Revert of CL 722703002 due to build breakage (Closed)

Created:
6 years, 1 month ago by Mr4D (OOO till 08-26)
Modified:
6 years, 1 month ago
Reviewers:
dharani1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of CL 722703002 due to build breakage BUG=435615 TEST=- Committed: https://chromium.googlesource.com/chromium/src/+/bad38cd9f3199784a10cdb99de9184c9055bef28

Patch Set 1 #

Patch Set 2 : revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -242 lines) Patch
M athena/extensions/chrome/extensions_delegate_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 9 chunks +14 lines, -23 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_window_browsertest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_manager_util.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor_browsertest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.cc View 1 4 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M components/sessions/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.cc View 1 1 chunk +1 line, -12 lines 0 comments Download
M extensions/common/api/app_runtime.idl View 1 1 chunk +2 lines, -7 lines 0 comments Download
M extensions/common/constants.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mr4D (OOO till 08-26)
Have a look.
6 years, 1 month ago (2014-11-15 05:35:26 UTC) #2
sky
If you contribute some substantial fixes that are more than moving functions around I'm happy ...
6 years, 1 month ago (2014-11-17 15:58:14 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bad38cd9f3199784a10cdb99de9184c9055bef28 Cr-Commit-Position: refs/heads/master@{#305246}
6 years, 1 month ago (2014-11-21 18:34:10 UTC) #4
Mr4D (OOO till 08-26)
6 years, 1 month ago (2014-11-21 18:34:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bad38cd9f3199784a10cdb99de9184c9055bef28.

Powered by Google App Engine
This is Rietveld 408576698