Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 720633003: Revert of CL 722703002 due to build breakage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/extensions/chrome/extensions_delegate_impl.cc ('k') | chrome/browser/apps/app_browsertest_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 7d604b44cbc58db7570f468cf2c6585bf01c9687..9db785e809d5d34c9293311b44ce72a5e98bdf2c 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
@@ -43,11 +42,9 @@
#include "extensions/browser/notification_types.h"
#include "extensions/browser/pref_names.h"
#include "extensions/common/api/app_runtime.h"
-#include "extensions/common/constants.h"
#include "extensions/test/extension_test_message_listener.h"
#include "extensions/test/result_catcher.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
-#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
#if defined(OS_CHROMEOS)
@@ -511,8 +508,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, LaunchWithRelativeFile) {
ASSERT_TRUE(extension);
// Run the test
- AppLaunchParams params(browser()->profile(), extension, LAUNCH_CONTAINER_NONE,
- NEW_WINDOW, extensions::SOURCE_UNTRACKED);
+ AppLaunchParams params(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW);
params.command_line = *CommandLine::ForCurrentProcess();
params.current_directory = test_data_dir_;
OpenApplication(params);
@@ -841,9 +838,8 @@ void PlatformAppDevToolsBrowserTest::RunTestWithDevTools(
content::WindowedNotificationObserver app_loaded_observer(
content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
content::NotificationService::AllSources());
- OpenApplication(AppLaunchParams(browser()->profile(), extension,
- LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));
app_loaded_observer.Wait();
window = GetFirstAppWindow();
ASSERT_TRUE(window);
@@ -987,9 +983,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
ASSERT_TRUE(should_install.seen());
ExtensionTestMessageListener launched_listener("Launched", false);
- OpenApplication(AppLaunchParams(browser()->profile(), extension,
- LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));
ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
}
@@ -1011,9 +1006,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
ASSERT_TRUE(extension);
ExtensionTestMessageListener launched_listener("Launched", false);
- OpenApplication(AppLaunchParams(browser()->profile(), extension,
- LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));
ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
ASSERT_FALSE(should_not_install.seen());
@@ -1049,9 +1043,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ComponentAppBackgroundPage) {
ASSERT_TRUE(should_install.seen());
ExtensionTestMessageListener launched_listener("Launched", false);
- OpenApplication(AppLaunchParams(browser()->profile(), extension,
- LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));
ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
}
@@ -1073,9 +1066,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
{
ExtensionTestMessageListener launched_listener("Launched", false);
- OpenApplication(AppLaunchParams(browser()->profile(), extension,
- LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));
ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
}
@@ -1225,9 +1217,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppIncognitoBrowserTest, IncognitoComponentApp) {
ASSERT_TRUE(registry != NULL);
registry->AddObserver(this);
- OpenApplication(AppLaunchParams(incognito_profile, file_manager, CURRENT_TAB,
- chrome::HOST_DESKTOP_TYPE_NATIVE,
- extensions::SOURCE_UNTRACKED));
+ OpenApplication(AppLaunchParams(
+ incognito_profile, file_manager, 0, chrome::HOST_DESKTOP_TYPE_NATIVE));
while (!ContainsKey(opener_app_ids_, file_manager->id())) {
content::RunAllPendingInMessageLoop();
« no previous file with comments | « athena/extensions/chrome/extensions_delegate_impl.cc ('k') | chrome/browser/apps/app_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698