Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

Issue 720633003: Revert of CL 722703002 due to build breakage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc
index 56d7d2476862879fa423417cba44ef577a4edab2..f616847648f526750f66d878e40ff2bb7a6b4cd8 100644
--- a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc
@@ -12,15 +12,12 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/web_contents.h"
#include "extensions/browser/extension_system.h"
-#include "extensions/common/constants.h"
-#include "ui/base/window_open_disposition.h"
ChromeNewWindowDelegateChromeos::ChromeNewWindowDelegateChromeos() {}
ChromeNewWindowDelegateChromeos::~ChromeNewWindowDelegateChromeos() {}
@@ -38,9 +35,12 @@ void ChromeNewWindowDelegateChromeos::OpenFileManager() {
const extensions::Extension* const extension =
service->GetInstalledExtension(kFileManagerAppId);
- OpenApplication(AppLaunchParams(profile, extension, CURRENT_TAB,
- chrome::HOST_DESKTOP_TYPE_ASH,
- extensions::SOURCE_CHROME_INTERNAL));
+ // event_flags = 0 means this invokes the same behavior as the launcher
+ // item is clicked without any keyboard modifiers.
+ OpenApplication(AppLaunchParams(profile,
+ extension,
+ 0 /* event_flags */,
+ chrome::HOST_DESKTOP_TYPE_ASH));
}
void ChromeNewWindowDelegateChromeos::OpenCrosh() {

Powered by Google App Engine
This is Rietveld 408576698