Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: chrome/browser/ui/chrome_pages.cc

Issue 720633003: Revert of CL 722703002 due to build breakage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/chrome_pages.h" 5 #include "chrome/browser/ui/chrome_pages.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "chrome/browser/download/download_shelf.h" 11 #include "chrome/browser/download/download_shelf.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/profiles/profile_manager.h" 13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_finder.h" 15 #include "chrome/browser/ui/browser_finder.h"
16 #include "chrome/browser/ui/browser_navigator.h" 16 #include "chrome/browser/ui/browser_navigator.h"
17 #include "chrome/browser/ui/browser_window.h" 17 #include "chrome/browser/ui/browser_window.h"
18 #include "chrome/browser/ui/extensions/app_launch_params.h"
19 #include "chrome/browser/ui/extensions/application_launch.h" 18 #include "chrome/browser/ui/extensions/application_launch.h"
20 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h" 19 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
21 #include "chrome/browser/ui/settings_window_manager.h" 20 #include "chrome/browser/ui/settings_window_manager.h"
22 #include "chrome/browser/ui/singleton_tabs.h" 21 #include "chrome/browser/ui/singleton_tabs.h"
23 #include "chrome/browser/ui/tabs/tab_strip_model.h" 22 #include "chrome/browser/ui/tabs/tab_strip_model.h"
24 #include "chrome/browser/ui/webui/options/content_settings_handler.h" 23 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
25 #include "chrome/common/chrome_switches.h" 24 #include "chrome/common/chrome_switches.h"
26 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
27 #include "content/public/browser/user_metrics.h" 26 #include "content/public/browser/user_metrics.h"
28 #include "content/public/browser/web_contents.h" 27 #include "content/public/browser/web_contents.h"
29 #include "extensions/common/constants.h"
30 #include "google_apis/gaia/gaia_urls.h" 28 #include "google_apis/gaia/gaia_urls.h"
31 #include "net/base/url_util.h" 29 #include "net/base/url_util.h"
32 #include "ui/base/window_open_disposition.h"
33 30
34 #if defined(OS_WIN) 31 #if defined(OS_WIN)
35 #include "chrome/browser/enumerate_modules_model_win.h" 32 #include "chrome/browser/enumerate_modules_model_win.h"
36 #endif 33 #endif
37 34
38 #if defined(OS_CHROMEOS) 35 #if defined(OS_CHROMEOS)
39 #include "chrome/browser/chromeos/genius_app/app_id.h" 36 #include "chrome/browser/chromeos/genius_app/app_id.h"
40 #include "extensions/browser/extension_registry.h" 37 #include "extensions/browser/extension_registry.h"
41 #endif 38 #endif
42 39
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 void ShowHelpImpl(Browser* browser, 75 void ShowHelpImpl(Browser* browser,
79 Profile* profile, 76 Profile* profile,
80 HostDesktopType host_desktop_type, 77 HostDesktopType host_desktop_type,
81 HelpSource source) { 78 HelpSource source) {
82 content::RecordAction(UserMetricsAction("ShowHelpTab")); 79 content::RecordAction(UserMetricsAction("ShowHelpTab"));
83 #if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD) 80 #if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
84 const extensions::Extension* extension = 81 const extensions::Extension* extension =
85 extensions::ExtensionRegistry::Get(profile)->GetExtensionById( 82 extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
86 genius_app::kGeniusAppId, 83 genius_app::kGeniusAppId,
87 extensions::ExtensionRegistry::EVERYTHING); 84 extensions::ExtensionRegistry::EVERYTHING);
88 extensions::AppLaunchSource app_launch_source(extensions::SOURCE_UNTRACKED); 85 AppLaunchParams params(profile, extension, 0, host_desktop_type);
89 switch (source) { 86 switch (source) {
90 case HELP_SOURCE_KEYBOARD: 87 case HELP_SOURCE_KEYBOARD:
91 app_launch_source = extensions::SOURCE_KEYBOARD; 88 params.source = extensions::SOURCE_KEYBOARD;
92 break; 89 break;
93 case HELP_SOURCE_MENU: 90 case HELP_SOURCE_MENU:
94 app_launch_source = extensions::SOURCE_SYSTEM_TRAY; 91 params.source = extensions::SOURCE_SYSTEM_TRAY;
95 break; 92 break;
96 case HELP_SOURCE_WEBUI: 93 case HELP_SOURCE_WEBUI:
97 app_launch_source = extensions::SOURCE_ABOUT_PAGE; 94 params.source = extensions::SOURCE_ABOUT_PAGE;
98 break; 95 break;
99 default:
100 NOTREACHED() << "Unhandled help source" << source;
101 } 96 }
102 AppLaunchParams params(profile, extension, CURRENT_TAB, host_desktop_type,
103 app_launch_source);
104 OpenApplication(params); 97 OpenApplication(params);
105 #else 98 #else
106 GURL url; 99 GURL url;
107 switch (source) { 100 switch (source) {
108 case HELP_SOURCE_KEYBOARD: 101 case HELP_SOURCE_KEYBOARD:
109 url = GURL(kChromeHelpViaKeyboardURL); 102 url = GURL(kChromeHelpViaKeyboardURL);
110 break; 103 break;
111 case HELP_SOURCE_MENU: 104 case HELP_SOURCE_MENU:
112 url = GURL(kChromeHelpViaMenuURL); 105 url = GURL(kChromeHelpViaMenuURL);
113 break; 106 break;
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 browser = displayer->browser(); 340 browser = displayer->browser();
348 } 341 }
349 342
350 NavigateToSingletonTab(browser, GURL(signin::GetPromoURL(source, false))); 343 NavigateToSingletonTab(browser, GURL(signin::GetPromoURL(source, false)));
351 DCHECK_GT(browser->tab_strip_model()->count(), 0); 344 DCHECK_GT(browser->tab_strip_model()->count(), 0);
352 } 345 }
353 } 346 }
354 #endif 347 #endif
355 348
356 } // namespace chrome 349 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698