Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 720033003: Update to VS2013 Update 4, and Windows SDK 8.1 (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years ago
CC:
chromium-reviews, Sébastien Marchand, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update to VS2013 Update 4, and Windows SDK 8.1 - Disable 4996 (deprecated functions in 8.1, these don't help us because we have to run on old OSs anyway) - Simplify Bluetooth LE header hacks (these headers are buggy in 8.0 and 8.1 SDKs, but less buggy in 8.1) - Revert attempt to centralize toolchain hashes as it didn't work well, and made it hard to roll anyway (see 400830). - Instead of basing C4702 (unreachable code) on Pro vs. Express, check whether it's actually disabled in the xtree header - Remove automatic calling of Express toolchain setup script. It hasn't worked well since post VS2013 RTM because of being distributed as .msp files, and the new Community edition is relatively easy to install so can subsume that usage (that being the motivation for the 4702 change above) - goma package for u4 is pushed - ANGLE is switched to load d3dcompiler_47 and build against 8.1 sdk, roll included here. Xrefs: - https://codereview.chromium.org/719343004/ - https://chromium-review.googlesource.com/#/c/229616/ - b2/18365241 - https://codereview.chromium.org/733563003/ - https://codereview.chromium.org/732673002/ - https://codereview.chromium.org/729453004/ - https://chromereviews.googleplex.com/120597013/ BUG=311488, 432748, 400830 Committed: https://crrev.com/a6675a5f1f55e66b1d6625af6225d44f5d9b0f3d Cr-Commit-Position: refs/heads/master@{#304329}

Patch Set 1 #

Patch Set 2 : move hashes back to build #

Patch Set 3 : better xtree/4702 behaviour #

Patch Set 4 : remove express #

Patch Set 5 : landmine #

Patch Set 6 : 46 to 47 #

Patch Set 7 : roll angle to e1425d95ba #

Patch Set 8 : bump version #

Patch Set 9 : usrsctp #

Patch Set 10 : +x on .py #

Patch Set 11 : .gn #

Patch Set 12 : ntddi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -199 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +21 lines, -10 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M build/get_landmines.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A build/toolchain_vs2013.hash View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/vs_toolchain.py View 1 1 chunk +1 line, -2 lines 0 comments Download
A build/win_is_xtree_patched.py View 1 2 3 4 5 6 7 8 9 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/angle.isolate View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/content_gl_tests.isolate View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_defs_win.h View 1 chunk +11 lines, -175 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (7 generated)
scottmg
6 years, 1 month ago (2014-11-14 17:36:43 UTC) #2
scottmg
sorry, should have added: rpaquay: device/bluetooth cpu: build/ etc. pkasting: warning 4702 fyi sebmarchand: toolchain/pgo ...
6 years, 1 month ago (2014-11-14 17:41:17 UTC) #3
Sébastien Marchand
I've triggered a job on the Win PGO trybot (it's the first time we use ...
6 years, 1 month ago (2014-11-14 17:55:10 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-14 18:22:08 UTC) #6
scottmg
With `set GYP_DEFINES=component=shared_library branding=Chrome syzygy_optimize=1 chromium_win_pch=0` building ninja -C out\Release All_syzygy is ok. So, I'll ...
6 years, 1 month ago (2014-11-14 20:39:20 UTC) #7
scottmg
On 2014/11/14 20:39:20, scottmg wrote: > With `set GYP_DEFINES=component=shared_library branding=Chrome syzygy_optimize=1 > chromium_win_pch=0` building ninja ...
6 years, 1 month ago (2014-11-14 20:45:07 UTC) #8
rpaquay
device/bluetooth/bluetooth_low_energy_defs_win.h: lgtm and thanks!
6 years, 1 month ago (2014-11-14 21:58:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720033003/180001
6 years, 1 month ago (2014-11-14 22:45:12 UTC) #11
scottmg
+brettw for BUILD.gn owners
6 years, 1 month ago (2014-11-14 22:48:14 UTC) #13
brettw
lgtm
6 years, 1 month ago (2014-11-14 23:25:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720033003/200001
6 years, 1 month ago (2014-11-14 23:49:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720033003/220001
6 years, 1 month ago (2014-11-15 00:00:24 UTC) #19
commit-bot: I haz the power
Committed patchset #12 (id:220001)
6 years, 1 month ago (2014-11-15 01:37:58 UTC) #20
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/a6675a5f1f55e66b1d6625af6225d44f5d9b0f3d Cr-Commit-Position: refs/heads/master@{#304329}
6 years, 1 month ago (2014-11-15 01:38:38 UTC) #21
dshwang
Hi, I cannot download win toolchain in Win8 after this CL. Does anybody have same ...
6 years ago (2014-11-27 21:45:20 UTC) #22
scottmg
6 years ago (2014-12-01 18:11:10 UTC) #23
Message was sent while issue was closed.
On 2014/11/27 21:45:20, dshwang wrote:
> Hi, I cannot download win toolchain in Win8 after this CL. Does anybody have
> same experience?
> My error log is as follows:
> 
> Extracting
c:\users\dongsung\appdata\local\temp\tmpmk9t_g\WDK\libs_x64fre.msi...
> Copying to final location...
> Cleaning up temporaries...
> Traceback (most recent call last):
>   File "toolchain2013.py", line 494, in <module>
>     sys.exit(main())
>   File "toolchain2013.py", line 474, in main
>     GenerateSetEnvCmd(target_dir, not options.express)
>   File "toolchain2013.py", line 379, in GenerateSetEnvCmd
>     target_dir, r'win8sdk\bin\SetEnv.cmd'), 'w') as f:
> IOError: [Errno 2] No such file or directory:
>
'C:\\Chromium\\depot_tools\\win_toolchain\\vs2013_files\\win8sdk\\bin\\SetEnv.cmd'
> 
> Traceback (most recent call last):
>   File "C:\Chromium\depot_tools\win_toolchain\get_toolchain_if_necessary.py",
> line 271, in <module>
>     sys.exit(main())
>   File "C:\Chromium\depot_tools\win_toolchain\get_toolchain_if_necessary.py",
> line 253, in main
>     subprocess.check_call(args)
>   File "C:\Chromium\depot_tools\python276_bin\lib\subprocess.py", line 540, in
> check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command
> '['C:\\Chromium\\depot_tools\\python276_bin\\python.exe', 'toolchain2013.py',
> '--targetdir', 'vs2013_files', '--sha1', 'e
> e7d718ec60c2dc5d255bbe325909c2021a7efef', '--express']' returned non-zero exit
> status 1
> Traceback (most recent call last):
>   File "src/build/vs_toolchain.py", line 223, in <module>
>     sys.exit(main())
>   File "src/build/vs_toolchain.py", line 219, in main
>     return commands[sys.argv[1]](*sys.argv[2:])
>   File "src/build/vs_toolchain.py", line 179, in Update
>     subprocess.check_call(get_toolchain_args)
>   File "C:\Chromium\depot_tools\python276_bin\lib\subprocess.py", line 540, in
> check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command
> '['C:\\Chromium\\depot_tools\\python276_bin\\python.exe',
> 'C:\\Chromium\\depot_tools\\win_toolchain\\get_toolchain_if_nec
> essary.py', '--output-json', 'c:\\Chromium\\src\\build\\win_toolchain.json',
> 'ee7d718ec60c2dc5d255bbe325909c2021a7efef']' returned non-zero exit status 1
> Error: Command C:\Chromium\depot_tools\python276_bin\python.exe
> src/build/vs_toolchain.py update returned non-zero exit status 1 in
c:\Chromium
> Hook ''C:\Chromium\depot_tools\python276_bin\python.exe'
> src/build/vs_toolchain.py update' took 831.80 secs

Hi, sorry about that. Express is no longer supported, I'll delete the script
today.

You should use Community or Professional now:
http://www.chromium.org/developers/how-tos/build-instructions-windows

Powered by Google App Engine
This is Rietveld 408576698