Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 732673002: Fix 8.1 sdk detection defines (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
tkent, Nico, yosin_UTC9
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix 8.1 sdk detection defines Checking the existence of _WIN32_WINNT_WINBLUE is incorrect, rather we should check that the value of _WIN32_WINNT is the desired value as that's the level that the headers are exposing. Also, move #include of windows.h up above check for include of versionhelpers.h, otherwise the defines are changed mid-file which causes problems. Also, fix typo in spelling of "condition". (Follow up to https://codereview.chromium.org/39693002) R=yosin@chromium.org, tkent@chromium.org BUG=311488, 432748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185390

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : fix order of includes so that defines are actually defined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/platform/win/SystemInfo.cpp View 1 2 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
6 years, 1 month ago (2014-11-14 18:03:12 UTC) #1
scottmg
+thakis due to timezone considerations
6 years, 1 month ago (2014-11-14 19:11:23 UTC) #3
Nico
timezones lgtm
6 years, 1 month ago (2014-11-14 19:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732673002/40001
6 years, 1 month ago (2014-11-14 19:19:02 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 20:24:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185390

Powered by Google App Engine
This is Rietveld 408576698