Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 719133002: Rename GrAccelData to SkLayerInfo and move it to src/core (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename GrAccelData to SkLayerInfo and move it to src/core Committed: https://skia.googlesource.com/skia/+/82365915476caedc130d0e36012a1ce0c007c4ae

Patch Set 1 #

Patch Set 2 : Fix up #includes a bit #

Patch Set 3 : Fix up unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -405 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -2 lines 0 comments Download
A + src/core/SkLayerInfo.h View 3 chunks +21 lines, -23 lines 0 comments Download
A + src/core/SkLayerInfo.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 3 chunks +4 lines, -17 lines 0 comments Download
M src/core/SkRecordDraw.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 8 chunks +20 lines, -27 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 4 chunks +13 lines, -12 lines 0 comments Download
D src/gpu/GrPictureUtils.h View 1 chunk +0 lines, -79 lines 0 comments Download
D src/gpu/GrPictureUtils.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 3 chunks +2 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 4 chunks +182 lines, -202 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robertphillips
6 years, 1 month ago (2014-11-12 16:48:21 UTC) #3
mtklein
lgtm
6 years, 1 month ago (2014-11-12 17:12:10 UTC) #4
bsalomon
On 2014/11/12 17:12:10, mtklein wrote: > lgtm lgtm
6 years, 1 month ago (2014-11-12 17:22:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719133002/40001
6 years, 1 month ago (2014-11-12 17:23:08 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 17:32:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/82365915476caedc130d0e36012a1ce0c007c4ae

Powered by Google App Engine
This is Rietveld 408576698