Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role. (Closed)

Created:
6 years, 1 month ago by shreeramk

Modified:
6 years, 1 month ago

Reviewers:
dmazzoni

CC:
blink-reviews, dmazzoni, aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Input type number should return SpinButtonRole from blink to chromium side to expose w correct role. This patch would return SpinButtonRole for input type number. So, that input type attribute "number" could be exposed similar to ARIA role spinbutton. This is in accordance with following http://rawgit.com/w3c/aria/master/html-aam/html-aam.html Note: I am facing problem in rebasing this https://codereview.chromium.org/653433002/ CL. So, I'm continuing the same in this new CL. BUG=385014 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185056

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/accessibility/AXNodeObject.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718433002/20001

6 years, 1 month ago (2014-11-10 18:18:09 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-10 19:18:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 185056