Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding layout test in test expectations Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 if (type == InputTypeNames::datetime 218 if (type == InputTypeNames::datetime
219 || type == InputTypeNames::datetime_local 219 || type == InputTypeNames::datetime_local
220 || type == InputTypeNames::month 220 || type == InputTypeNames::month
221 || type == InputTypeNames::week) 221 || type == InputTypeNames::week)
222 return DateTimeRole; 222 return DateTimeRole;
223 if (type == InputTypeNames::radio) { 223 if (type == InputTypeNames::radio) {
224 if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode()) ) || (parentObject() && parentObject()->roleValue() == MenuRole)) 224 if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode()) ) || (parentObject() && parentObject()->roleValue() == MenuRole))
225 return MenuItemRadioRole; 225 return MenuItemRadioRole;
226 return RadioButtonRole; 226 return RadioButtonRole;
227 } 227 }
228 if (type == InputTypeNames::number)
229 return SpinButtonRole;
228 if (input.isTextButton()) 230 if (input.isTextButton())
229 return buttonRoleType(); 231 return buttonRoleType();
230 if (type == InputTypeNames::range) 232 if (type == InputTypeNames::range)
231 return SliderRole; 233 return SliderRole;
232 if (type == InputTypeNames::color) 234 if (type == InputTypeNames::color)
233 return ColorWellRole; 235 return ColorWellRole;
234 if (type == InputTypeNames::time) 236 if (type == InputTypeNames::time)
235 return TimeRole; 237 return TimeRole;
236 return TextFieldRole; 238 return TextFieldRole;
237 } 239 }
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1774 float range = maxValueForRange() - minValueForRange(); 1776 float range = maxValueForRange() - minValueForRange();
1775 float value = valueForRange(); 1777 float value = valueForRange();
1776 1778
1777 value += range * (percentChange / 100); 1779 value += range * (percentChange / 100);
1778 setValue(String::number(value)); 1780 setValue(String::number(value));
1779 1781
1780 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true); 1782 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
1781 } 1783 }
1782 1784
1783 } // namespace blink 1785 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698