Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding layout test in test expectations Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 if (type == InputTypeNames::datetime 328 if (type == InputTypeNames::datetime
329 || type == InputTypeNames::datetime_local 329 || type == InputTypeNames::datetime_local
330 || type == InputTypeNames::month 330 || type == InputTypeNames::month
331 || type == InputTypeNames::week) 331 || type == InputTypeNames::week)
332 return DateTimeRole; 332 return DateTimeRole;
333 if (type == InputTypeNames::radio) { 333 if (type == InputTypeNames::radio) {
334 if ((node->parentNode() && isHTMLMenuElement(node->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole)) 334 if ((node->parentNode() && isHTMLMenuElement(node->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
335 return MenuItemRadioRole; 335 return MenuItemRadioRole;
336 return RadioButtonRole; 336 return RadioButtonRole;
337 } 337 }
338 if (type == InputTypeNames::number)
339 return SpinButtonRole;
338 if (input.isTextButton()) 340 if (input.isTextButton())
339 return buttonRoleType(); 341 return buttonRoleType();
340 if (type == InputTypeNames::color) 342 if (type == InputTypeNames::color)
341 return ColorWellRole; 343 return ColorWellRole;
342 if (type == InputTypeNames::time) 344 if (type == InputTypeNames::time)
343 return TimeRole; 345 return TimeRole;
344 } 346 }
345 347
346 if (isFileUploadButton()) 348 if (isFileUploadButton())
347 return ButtonRole; 349 return ButtonRole;
(...skipping 2087 matching lines...) Expand 10 before | Expand all | Expand 10 after
2435 if (label && label->renderer()) { 2437 if (label && label->renderer()) {
2436 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2438 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2437 result.unite(labelRect); 2439 result.unite(labelRect);
2438 } 2440 }
2439 } 2441 }
2440 2442
2441 return result; 2443 return result;
2442 } 2444 }
2443 2445
2444 } // namespace blink 2446 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698