Source/core/accessibility/AXNodeObject.cpp - Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 718433002: Input type number should return SpinButtonRole from blink to chromium side to expose w correct role. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding layout test in test expectations Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index 917f64a04c8d02f4d37d2d1937f2474c6f17f19c..35c842a261b13b2b23318087c434a50d4b7a0f82 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -225,6 +225,8 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

return MenuItemRadioRole;

return RadioButtonRole;

}

+ if (type == InputTypeNames::number)

+ return SpinButtonRole;

if (input.isTextButton())

return buttonRoleType();

if (type == InputTypeNames::range)

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »