Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 717243002: Timeline: do not imply event.thread.target is the main target (Closed)

Created:
6 years, 1 month ago by caseq
Modified:
6 years, 1 month ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Timeline: do not imply event.thread.target is the main target We used to rely on event.thread.target in multiple places where target was needed. These places mostly imply that this was a main target (i.e. using it to get DOMModel & co), while it can now be a different (or null) target. Let's keep main target associated with timeline in Timeline model (and perhaps return null for recorded timelines later) and plumb it where it is necessary. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185294

Patch Set 1 #

Patch Set 2 : remove test expectation from moved test #

Total comments: 1

Patch Set 3 : addressed review comments, fixed a test #

Patch Set 4 : avoid keep stale model in TimelineFrameModel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -168 lines) Patch
M LayoutTests/http/tests/inspector/layers-test.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/inspector/layers/tracing-layer-tree.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/inspector/layers/tracing-layer-tree-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/inspector/tracing/frame-model.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/tracing/layer-tree.html View 2 chunks +19 lines, -22 lines 0 comments Download
A + LayoutTests/inspector/tracing/layer-tree-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-event-causes.html View 4 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-id.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/implsidepainting/inspector/tracing/paint-command-log-nodes.html View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/TracingManager.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 2 3 8 chunks +29 lines, -23 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 11 chunks +25 lines, -19 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
caseq
6 years, 1 month ago (2014-11-12 17:30:03 UTC) #2
alph
lgtm https://codereview.chromium.org/717243002/diff/20001/Source/devtools/front_end/timeline/TimelineFrameModel.js File Source/devtools/front_end/timeline/TimelineFrameModel.js (right): https://codereview.chromium.org/717243002/diff/20001/Source/devtools/front_end/timeline/TimelineFrameModel.js#newcode268 Source/devtools/front_end/timeline/TimelineFrameModel.js:268: else { should be on the previous line
6 years, 1 month ago (2014-11-13 11:11:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717243002/40001
6 years, 1 month ago (2014-11-13 12:58:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717243002/60001
6 years, 1 month ago (2014-11-13 14:03:54 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 15:05:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 185294

Powered by Google App Engine
This is Rietveld 408576698