Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 717243002: Timeline: do not imply event.thread.target is the main target (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: avoid keep stale model in TimelineFrameModel Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineView.js
diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js
index 8b3fbe23141bf40a8080101b79830c72ad70a85a..6e81b08ad31bea3d0cf95a448da3344d06b7a57b 100644
--- a/Source/devtools/front_end/timeline/TimelineView.js
+++ b/Source/devtools/front_end/timeline/TimelineView.js
@@ -567,7 +567,7 @@ WebInspector.TimelineView.prototype = {
}
} else {
if (!listRowElement) {
- listRowElement = new WebInspector.TimelineRecordListRow(this._linkifier, selectRecordCallback, scheduleRefreshCallback).element;
+ listRowElement = new WebInspector.TimelineRecordListRow(this._linkifier, this._model.target(), selectRecordCallback, scheduleRefreshCallback).element;
this._sidebarListElement.appendChild(listRowElement);
}
if (!graphRowElement) {
@@ -1019,9 +1019,10 @@ WebInspector.TimelineCalculator.prototype = {
* @constructor
* @param {!WebInspector.Linkifier} linkifier
* @param {function(!WebInspector.TimelinePresentationModel.Record)} selectRecord
+ * @param {?WebInspector.Target} target
* @param {function()} scheduleRefresh
*/
-WebInspector.TimelineRecordListRow = function(linkifier, selectRecord, scheduleRefresh)
+WebInspector.TimelineRecordListRow = function(linkifier, target, selectRecord, scheduleRefresh)
{
this.element = createElement("div");
this.element.row = this;
@@ -1042,6 +1043,7 @@ WebInspector.TimelineRecordListRow = function(linkifier, selectRecord, scheduleR
this._dataElement = this.element.createChild("span", "data dimmed");
this._scheduleRefresh = scheduleRefresh;
this._selectRecord = selectRecord;
+ this._target = target;
}
WebInspector.TimelineRecordListRow.prototype = {
@@ -1075,7 +1077,7 @@ WebInspector.TimelineRecordListRow.prototype = {
if (presentationRecord.coalesced()) {
this._dataElement.createTextChild(WebInspector.UIString("× %d", presentationRecord.presentationChildren().length));
} else {
- var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(record.traceEvent(), this._linkifier);
+ var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(record.traceEvent(), this._target, this._linkifier);
if (detailsNode) {
this._dataElement.createTextChild("(");
this._dataElement.appendChild(detailsNode);
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698