Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 717243002: Timeline: do not imply event.thread.target is the main target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 717243002: Timeline: do not imply event.thread.target is the main target (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: avoid keep stale model in TimelineFrameModel Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js

index 89118f68eac011d8230dc3eb7ab72a11408fdd01..cf0871b7dd243438c6881fbcae1ea1856d0761ce 100644

--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -111,7 +111,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

var name = WebInspector.TimelineUIUtils.eventStyle(event).title;

// TODO(yurys): support event dividers

- var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier);

+ var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._model.target(), this._linkifier);

if (event.name === WebInspector.TimelineModel.RecordType.JSFrame && details)

return details.textContent;

return details ? WebInspector.UIString("%s (%s)", name, details.textContent) : name;