LayoutTests/inspector/tracing/timeline-event-causes.html - Issue 717243002: Timeline: do not imply event.thread.target is the main target

Unified Diff: LayoutTests/inspector/tracing/timeline-event-causes.html

Issue 717243002: Timeline: do not imply event.thread.target is the main target (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: avoid keep stale model in TimelineFrameModel Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/tracing/layer-tree-expected.txt ('k') | LayoutTests/inspector/tracing/timeline-script-id.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/tracing/timeline-event-causes.html

diff --git a/LayoutTests/inspector/tracing/timeline-event-causes.html b/LayoutTests/inspector/tracing/timeline-event-causes.html

index 910f339a6c24899785fda09a7db706a8a32b8c41..c9ff5662d4b550b3afb748de4b7d6a43de439f6b 100644

--- a/LayoutTests/inspector/tracing/timeline-event-causes.html

+++ b/LayoutTests/inspector/tracing/timeline-event-causes.html

@@ -30,8 +30,8 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("TimerFire");

InspectorTest.check(record, "Should receive a TimerFire record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(record.traceEvent().thread.target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), contentHelper);

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), contentHelper);

var causes = contentHelper.element.textContent;

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Timer installedsetTimeoutFunction @ setTimeoutFunction.js:");

@@ -56,8 +56,8 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("FireAnimationFrame");

InspectorTest.check(record, "Should receive a FireAnimationFrame record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(record.traceEvent().thread.target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), contentHelper);

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), contentHelper);

var causes = contentHelper.element.textContent;

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Animation frame requestedrequestAnimationFrameFunction @ requestAnimationFrameFunction.js:");

@@ -84,8 +84,8 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("RecalculateStyles");

InspectorTest.check(record, "Should receive a RecalculateStyles record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(record.traceEvent().thread.target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), contentHelper);

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), contentHelper);

var causes = contentHelper.element.textContent;

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "First invalidatedstyleRecalcFunction @ styleRecalcFunction.js:");

@@ -113,8 +113,8 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("Layout");

InspectorTest.check(record, "Should receive a Layout record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(record.traceEvent().thread.target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), contentHelper);

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), contentHelper);

var causes = contentHelper.element.textContent;

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Layout forcedlayoutFunction @ layoutFunction.js:");

« no previous file with comments | « LayoutTests/inspector/tracing/layer-tree-expected.txt ('k') | LayoutTests/inspector/tracing/timeline-script-id.html » ('j') | no next file with comments »