components/tracing/tracing_messages.h - Issue 717083003: Report trace buffer usage as number of events, not only percentage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/tracing_messages.h

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/tracing/child_trace_message_filter.cc ('k') | content/browser/browser_shutdown_profile_dumper.cc » ('j') | content/browser/browser_shutdown_profile_dumper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/tracing_messages.h

diff --git a/components/tracing/tracing_messages.h b/components/tracing/tracing_messages.h

index ff891a0edaab768491d72a13c00c684c9ec93e4a..f2a36631eb94244620f759fecf26a849afe6624a 100644

--- a/components/tracing/tracing_messages.h

+++ b/components/tracing/tracing_messages.h

@@ -37,7 +37,7 @@ IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring)

IPC_MESSAGE_CONTROL0(TracingMsg_CaptureMonitoringSnapshot)

// Sent to all child processes to get trace buffer fullness.

-IPC_MESSAGE_CONTROL0(TracingMsg_GetTraceBufferPercentFull)

+IPC_MESSAGE_CONTROL0(TracingMsg_GetTraceBufferUsage)

// Sent to all child processes to set watch event.

IPC_MESSAGE_CONTROL2(TracingMsg_SetWatchEvent,

@@ -69,7 +69,7 @@ IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceDataCollected,

IPC_MESSAGE_CONTROL1(TracingHostMsg_MonitoringTraceDataCollected,

std::string /*json trace data*/)

-// Reply to TracingMsg_GetTraceBufferPercentFull.

-IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceBufferPercentFullReply,

- float /*trace buffer percent full*/)

+// Reply to TracingMsg_GetTraceBufferUsage.

+IPC_MESSAGE_CONTROL2(TracingHostMsg_TraceBufferUsageReply,

+ float /*trace buffer percent full*/,

+ size_t /*trace buffer usage in number of events*/)

alph 2014/11/14 10:59:30 nit: Having it contain size and capacity instead w

yurys 2014/11/14 13:03:47 Done.