Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: components/tracing/tracing_messages.h

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included message header, no traditional include guard. 5 // Multiply-included message header, no traditional include guard.
6 #include <string> 6 #include <string>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/sync_socket.h" 10 #include "base/sync_socket.h"
(...skipping 19 matching lines...) Expand all
30 base::TimeTicks /* browser_time */, 30 base::TimeTicks /* browser_time */,
31 std::string /* base::debug::TraceOptions */) 31 std::string /* base::debug::TraceOptions */)
32 32
33 // Sent to all child processes to stop monitoring. 33 // Sent to all child processes to stop monitoring.
34 IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring) 34 IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring)
35 35
36 // Sent to all child processes to capture the current monitorint snapshot. 36 // Sent to all child processes to capture the current monitorint snapshot.
37 IPC_MESSAGE_CONTROL0(TracingMsg_CaptureMonitoringSnapshot) 37 IPC_MESSAGE_CONTROL0(TracingMsg_CaptureMonitoringSnapshot)
38 38
39 // Sent to all child processes to get trace buffer fullness. 39 // Sent to all child processes to get trace buffer fullness.
40 IPC_MESSAGE_CONTROL0(TracingMsg_GetTraceBufferPercentFull) 40 IPC_MESSAGE_CONTROL0(TracingMsg_GetTraceBufferUsage)
41 41
42 // Sent to all child processes to set watch event. 42 // Sent to all child processes to set watch event.
43 IPC_MESSAGE_CONTROL2(TracingMsg_SetWatchEvent, 43 IPC_MESSAGE_CONTROL2(TracingMsg_SetWatchEvent,
44 std::string /* category_name */, 44 std::string /* category_name */,
45 std::string /* event_name */) 45 std::string /* event_name */)
46 46
47 // Sent to all child processes to clear watch event. 47 // Sent to all child processes to clear watch event.
48 IPC_MESSAGE_CONTROL0(TracingMsg_CancelWatchEvent) 48 IPC_MESSAGE_CONTROL0(TracingMsg_CancelWatchEvent)
49 49
50 // Sent everytime when a watch event is matched. 50 // Sent everytime when a watch event is matched.
(...skipping 11 matching lines...) Expand all
62 62
63 // Child processes send back trace data in JSON chunks. 63 // Child processes send back trace data in JSON chunks.
64 IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceDataCollected, 64 IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceDataCollected,
65 std::string /*json trace data*/) 65 std::string /*json trace data*/)
66 66
67 // Child processes send back trace data of the current monitoring 67 // Child processes send back trace data of the current monitoring
68 // in JSON chunks. 68 // in JSON chunks.
69 IPC_MESSAGE_CONTROL1(TracingHostMsg_MonitoringTraceDataCollected, 69 IPC_MESSAGE_CONTROL1(TracingHostMsg_MonitoringTraceDataCollected,
70 std::string /*json trace data*/) 70 std::string /*json trace data*/)
71 71
72 // Reply to TracingMsg_GetTraceBufferPercentFull. 72 // Reply to TracingMsg_GetTraceBufferUsage.
73 IPC_MESSAGE_CONTROL1(TracingHostMsg_TraceBufferPercentFullReply, 73 IPC_MESSAGE_CONTROL2(TracingHostMsg_TraceBufferUsageReply,
74 float /*trace buffer percent full*/) 74 float /*trace buffer percent full*/,
75 75 size_t /*trace buffer usage in number of events*/)
alph 2014/11/14 10:59:30 nit: Having it contain size and capacity instead w
yurys 2014/11/14 13:03:47 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698