Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: components/tracing/child_trace_message_filter.cc

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/child_trace_message_filter.cc
diff --git a/components/tracing/child_trace_message_filter.cc b/components/tracing/child_trace_message_filter.cc
index fe13ff57dd08ca8d7038c7c38ad091bafa18e145..aef6aa4697a665269fea564fe69299c89f66f508 100644
--- a/components/tracing/child_trace_message_filter.cc
+++ b/components/tracing/child_trace_message_filter.cc
@@ -36,8 +36,7 @@ bool ChildTraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(TracingMsg_DisableMonitoring, OnDisableMonitoring)
IPC_MESSAGE_HANDLER(TracingMsg_CaptureMonitoringSnapshot,
OnCaptureMonitoringSnapshot)
- IPC_MESSAGE_HANDLER(TracingMsg_GetTraceBufferPercentFull,
- OnGetTraceBufferPercentFull)
+ IPC_MESSAGE_HANDLER(TracingMsg_GetTraceBufferUsage, OnGetTraceBufferUsage)
IPC_MESSAGE_HANDLER(TracingMsg_SetWatchEvent, OnSetWatchEvent)
IPC_MESSAGE_HANDLER(TracingMsg_CancelWatchEvent, OnCancelWatchEvent)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -105,10 +104,11 @@ void ChildTraceMessageFilter::OnCaptureMonitoringSnapshot() {
this));
}
-void ChildTraceMessageFilter::OnGetTraceBufferPercentFull() {
- float bpf = TraceLog::GetInstance()->GetBufferPercentFull();
-
- sender_->Send(new TracingHostMsg_TraceBufferPercentFullReply(bpf));
+void ChildTraceMessageFilter::OnGetTraceBufferUsage() {
+ TraceLog::BufferUsage buffer_usage =
+ TraceLog::GetInstance()->GetBufferUsage();
+ sender_->Send(new TracingHostMsg_TraceBufferUsageReply(
+ buffer_usage.percent_full, buffer_usage.approximate_event_count));
}
void ChildTraceMessageFilter::OnSetWatchEvent(const std::string& category_name,

Powered by Google App Engine
This is Rietveld 408576698