content/browser/browser_shutdown_profile_dumper.cc - Issue 717083003: Report trace buffer usage as number of events, not only percentage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_shutdown_profile_dumper.cc

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/tracing/tracing_messages.h ('K') | « components/tracing/tracing_messages.h ('k') | content/browser/devtools/protocol/tracing_handler.h » ('j') | content/browser/tracing/tracing_controller_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_shutdown_profile_dumper.cc

diff --git a/content/browser/browser_shutdown_profile_dumper.cc b/content/browser/browser_shutdown_profile_dumper.cc

index c2533a09604cbe7a5490d55758acc4844e4a3f99..b853a70ee6958de8d3479d4d864e6c3ec57293f5 100644

--- a/content/browser/browser_shutdown_profile_dumper.cc

+++ b/content/browser/browser_shutdown_profile_dumper.cc

@@ -34,9 +34,10 @@ void BrowserShutdownProfileDumper::WriteTracesToDisc() {

// Since the tracer stops when the trace buffer is filled, we'd rather save

// what we have than nothing since we might see from the amount of events

// that caused the problem.

- DVLOG(1) << "Flushing shutdown traces to disc. The buffer is %" <<

- base::debug::TraceLog::GetInstance()->GetBufferPercentFull() <<

- " full.";

+ DVLOG(1) << "Flushing shutdown traces to disc. The buffer is %"

alph 2014/11/14 10:59:30 out of curiosity what does % mean here?

yurys 2014/11/14 13:03:47 No idea, it was here before. I believe it is just

+ << base::debug::TraceLog::GetInstance()

+ ->GetBufferUsage()

+ .approximate_event_count << " full.";

alph 2014/11/14 10:59:30 is the change from percent to count intentional?

yurys 2014/11/14 13:03:47 Good catch. Done.

DCHECK(!dump_file_);

dump_file_ = base::OpenFile(dump_file_name_, "w+");

if (!IsFileValid()) {