Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 716023002: Paint code cleanup: remove unnecessary indirections through the Render* code in several cases. (Closed)

Created:
6 years, 1 month ago by chrishtr
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Paint code cleanup: remove unnecessary indirections through the Render* code in several cases. BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185167

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M Source/core/paint/BlockPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ReplacedPainter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/TablePainter.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/paint/TableRowPainter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/TableSectionPainter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderPart.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishtr
6 years, 1 month ago (2014-11-12 00:04:24 UTC) #1
chrishtr
6 years, 1 month ago (2014-11-12 00:04:33 UTC) #3
leviw_travelin_and_unemployed
LGTM.
6 years, 1 month ago (2014-11-12 00:15:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716023002/20001
6 years, 1 month ago (2014-11-12 00:16:07 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 02:17:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185167

Powered by Google App Engine
This is Rietveld 408576698