Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 716023002: Paint code cleanup: remove unnecessary indirections through the Render* code in several cases. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/paint/TableSectionPainter.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 1131
1132 // Overrides should call the superclass at the end. m_style will be 0 the fi rst time 1132 // Overrides should call the superclass at the end. m_style will be 0 the fi rst time
1133 // this function will be called. 1133 // this function will be called.
1134 virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle); 1134 virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle);
1135 // Overrides should call the superclass at the start. |oldStyle| will be 0 t he first 1135 // Overrides should call the superclass at the start. |oldStyle| will be 0 t he first
1136 // time this function is called. 1136 // time this function is called.
1137 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle); 1137 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
1138 void propagateStyleToAnonymousChildren(bool blockChildrenOnly = false); 1138 void propagateStyleToAnonymousChildren(bool blockChildrenOnly = false);
1139 virtual void updateAnonymousChildStyle(const RenderObject* child, RenderStyl e* style) const { } 1139 virtual void updateAnonymousChildStyle(const RenderObject* child, RenderStyl e* style) const { }
1140 1140
1141 public:
1142 void paintOutline(PaintInfo&, const LayoutRect&);
1143 protected: 1141 protected:
1144 void addChildFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer) const; 1142 void addChildFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer) const;
1145 1143
1146 void clearLayoutRootIfNeeded() const; 1144 void clearLayoutRootIfNeeded() const;
1147 virtual void willBeDestroyed(); 1145 virtual void willBeDestroyed();
1148 void postDestroy(); 1146 void postDestroy();
1149 1147
1150 virtual void insertedIntoTree(); 1148 virtual void insertedIntoTree();
1151 virtual void willBeRemovedFromTree(); 1149 virtual void willBeRemovedFromTree();
1152 1150
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
1615 void showTree(const blink::RenderObject*); 1613 void showTree(const blink::RenderObject*);
1616 void showLineTree(const blink::RenderObject*); 1614 void showLineTree(const blink::RenderObject*);
1617 void showRenderTree(const blink::RenderObject* object1); 1615 void showRenderTree(const blink::RenderObject* object1);
1618 // We don't make object2 an optional parameter so that showRenderTree 1616 // We don't make object2 an optional parameter so that showRenderTree
1619 // can be called from gdb easily. 1617 // can be called from gdb easily.
1620 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 1618 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
1621 1619
1622 #endif 1620 #endif
1623 1621
1624 #endif // RenderObject_h 1622 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/paint/TableSectionPainter.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698