Source/core/paint/ReplacedPainter.cpp - Issue 716023002: Paint code cleanup: remove unnecessary indirections through the Render* code in several cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ReplacedPainter.cpp

Issue 716023002: Paint code cleanup: remove unnecessary indirections through the Render* code in several cases. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/ReplacedPainter.cpp

diff --git a/Source/core/paint/ReplacedPainter.cpp b/Source/core/paint/ReplacedPainter.cpp

index 80b518b32626d26a49dda6fdbd415cd9ba7f0fea..1962ee79dfae8be8eef6fd488f8d933516311cbb 100644

--- a/Source/core/paint/ReplacedPainter.cpp

+++ b/Source/core/paint/ReplacedPainter.cpp

@@ -6,6 +6,7 @@

#include "core/paint/ReplacedPainter.h"

#include "core/paint/BoxPainter.h"

+#include "core/paint/ObjectPainter.h"

#include "core/rendering/GraphicsContextAnnotator.h"

#include "core/rendering/PaintInfo.h"

#include "core/rendering/RenderLayer.h"

@@ -35,7 +36,7 @@ void ReplacedPainter::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset

LayoutRect paintRect = LayoutRect(adjustedPaintOffset, m_renderReplaced.size());

if ((paintInfo.phase == PaintPhaseOutline || paintInfo.phase == PaintPhaseSelfOutline) && m_renderReplaced.style()->outlineWidth())

- m_renderReplaced.paintOutline(paintInfo, paintRect);

+ ObjectPainter(m_renderReplaced).paintOutline(paintInfo, paintRect);

if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection && !m_renderReplaced.canHaveChildren() && paintInfo.phase != PaintPhaseClippingMask)

return;

« no previous file with comments | « Source/core/paint/BlockPainter.cpp ('k') | Source/core/paint/TablePainter.cpp » ('j') | no next file with comments »