Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 715623004: Merge 185075 "Revert paint-invalidation-container ASSERT" (Closed)

Created:
6 years, 1 month ago by Julien - ping for review
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Merge 185075 "Revert paint-invalidation-container ASSERT" > Revert paint-invalidation-container ASSERT > > This CL reverts > https://codereview.chromium.org/414503002 > > The RenderLayer change was wrong and is the cause of the regression. > Unfortunately it's unclear what the path forward is: the ASSERT is > triggering, which means there are some bugs in the code, but it is > caused by having several definitions of paint invalidation container. > Fixing it will require aligning these definitions and it's unclear > which one is right. > > BUG=415513 > > Review URL: https://codereview.chromium.org/706353002 TBR=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/offset-change-wrong-invalidation-with-float.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/repaint/offset-change-wrong-invalidation-with-float-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Julien - ping for review
6 years, 1 month ago (2014-11-11 00:56:16 UTC) #1
Julien - ping for review
6 years, 1 month ago (2014-11-11 00:56:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r185083.

Powered by Google App Engine
This is Rietveld 408576698