Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 414503002: Enable paint invalidation container ASSERT (Closed)

Created:
6 years, 5 months ago by Julien - ping for review
Modified:
6 years, 5 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Enable paint invalidation container ASSERT This ASSERT was disabled with repaint-after-layout. Now that we have moved invalidation after compositing update, we can enable it. The ASSERT uncovered a bug in RenderLayer::enclosingLayerForPaintInvalidation where we were walking over stacking contexts and not just renderers. BUG=360286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178935

Patch Set 1 #

Patch Set 2 : Dummy rebaseline for the picky trybots :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Julien - ping for review
6 years, 5 months ago (2014-07-22 19:32:51 UTC) #1
dsinclair
Should this be split into two CLs? One to fix the parent walking and one ...
6 years, 5 months ago (2014-07-22 19:36:50 UTC) #2
Julien - ping for review
On 2014/07/22 at 19:36:50, dsinclair wrote: > Should this be split into two CLs? One ...
6 years, 5 months ago (2014-07-22 20:34:01 UTC) #3
dsinclair
Fair enough, lgtm.
6 years, 5 months ago (2014-07-22 20:41:17 UTC) #4
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-07-23 00:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/414503002/1
6 years, 5 months ago (2014-07-23 00:01:37 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-07-23 00:04:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 00:07:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/10854)
6 years, 5 months ago (2014-07-23 00:07:06 UTC) #9
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 5 months ago (2014-07-23 17:20:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/414503002/20001
6 years, 5 months ago (2014-07-23 17:21:10 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-23 18:26:03 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 18:46:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32201)
6 years, 5 months ago (2014-07-23 18:46:37 UTC) #14
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 5 months ago (2014-07-25 14:46:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/414503002/20001
6 years, 5 months ago (2014-07-25 14:46:39 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 15:10:21 UTC) #17
Message was sent while issue was closed.
Change committed as 178935

Powered by Google App Engine
This is Rietveld 408576698