Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 706353002: Revert paint-invalidation-container ASSERT (Closed)

Created:
6 years, 1 month ago by Julien - ping for review
Modified:
6 years, 1 month ago
Reviewers:
dsinclair, Xianzhu
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert paint-invalidation-container ASSERT This CL reverts https://codereview.chromium.org/414503002 The RenderLayer change was wrong and is the cause of the regression. Unfortunately it's unclear what the path forward is: the ASSERT is triggering, which means there are some bugs in the code, but it is caused by having several definitions of paint invalidation container. Fixing it will require aligning these definitions and it's unclear which one is right. BUG=415513 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185075

Patch Set 1 #

Patch Set 2 : Added a missing test to rebaselin. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/offset-change-wrong-invalidation-with-float.html View 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/offset-change-wrong-invalidation-with-float-expected.txt View 1 chunk +39 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Julien - ping for review
6 years, 1 month ago (2014-11-10 16:27:42 UTC) #2
dsinclair
lgtm
6 years, 1 month ago (2014-11-10 16:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706353002/1
6 years, 1 month ago (2014-11-10 16:40:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30207)
6 years, 1 month ago (2014-11-10 22:09:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706353002/20001
6 years, 1 month ago (2014-11-10 22:25:49 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 00:11:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185075

Powered by Google App Engine
This is Rietveld 408576698