Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 713073003: remove updateTouchEventTargetRectsIfNeeded (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1051 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 7 chunks +2 lines, -25 lines 2 comments Download
D sky/engine/core/frame/EventHandlerRegistry.h View 1 chunk +0 lines, -104 lines 0 comments Download
D sky/engine/core/frame/EventHandlerRegistry.cpp View 1 chunk +0 lines, -240 lines 0 comments Download
M sky/engine/core/frame/FrameHost.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 5 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 2 chunks +3 lines, -5 lines 2 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 3 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 6 chunks +0 lines, -270 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 4 chunks +0 lines, -101 lines 0 comments Download
M sky/engine/core/rendering/RenderText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/public/web/WebWidgetClient.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
https://codereview.chromium.org/713073003/diff/40001/sky/engine/core/dom/Node.cpp File sky/engine/core/dom/Node.cpp (right): https://codereview.chromium.org/713073003/diff/40001/sky/engine/core/dom/Node.cpp#newcode1410 sky/engine/core/dom/Node.cpp:1410: return targetNode->EventTarget::removeEventListener(eventType, listener, useCapture); PTAL https://codereview.chromium.org/713073003/diff/40001/sky/engine/core/page/EventHandler.cpp File sky/engine/core/page/EventHandler.cpp (right): ...
6 years, 1 month ago (2014-11-10 20:31:22 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/713073003/diff/40001/sky/engine/core/dom/Node.cpp File sky/engine/core/dom/Node.cpp (right): https://codereview.chromium.org/713073003/diff/40001/sky/engine/core/dom/Node.cpp#newcode1410 sky/engine/core/dom/Node.cpp:1410: return targetNode->EventTarget::removeEventListener(eventType, listener, useCapture); On 2014/11/10 at 20:31:21, ...
6 years, 1 month ago (2014-11-10 21:03:42 UTC) #3
rafaelw
6 years, 1 month ago (2014-11-10 21:08:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
87f9e129081f930c98b11a62d74d0d82ed459ca8.

Powered by Google App Engine
This is Rietveld 408576698