Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: sky/engine/core/page/scrolling/ScrollingCoordinator.h

Issue 713073003: remove updateTouchEventTargetRectsIfNeeded (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: moar Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/page/scrolling/ScrollingCoordinator.h
diff --git a/sky/engine/core/page/scrolling/ScrollingCoordinator.h b/sky/engine/core/page/scrolling/ScrollingCoordinator.h
index 2ab98ce23914b60e4b498360fda698d2759ee228..2c5f2edaa39abcc23884c4c214e0432516c6bfdf 100644
--- a/sky/engine/core/page/scrolling/ScrollingCoordinator.h
+++ b/sky/engine/core/page/scrolling/ScrollingCoordinator.h
@@ -54,11 +54,6 @@ public:
void willBeDestroyed();
- // Called when any frame has done its layout.
- void notifyLayoutUpdated();
-
- void updateAfterCompositingChangeIfNeeded();
-
#if OS(MACOSX)
// Dispatched by the scrolling tree during handleWheelEvent. This is required as long as scrollbars are painted on the main thread.
void handleWheelEventPhase(PlatformWheelEventPhase);
@@ -70,14 +65,11 @@ public:
// Returns true if the coordinator handled this change.
bool scrollableAreaScrollLayerDidChange(ScrollableArea*);
void scrollableAreaScrollbarLayerDidChange(ScrollableArea*, ScrollbarOrientation);
- void touchEventTargetRectsDidChange();
void willDestroyRenderLayer(RenderLayer*);
void updateScrollParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* parent);
void updateClipParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* parent);
- void updateTouchEventTargetRectsIfNeeded();
-
// For testing purposes only. This ScrollingCoordinator is reused between layout test, and must be reset
// for the results to be valid.
void reset();
@@ -89,13 +81,7 @@ protected:
Page* m_page;
- // Dirty flags used to idenfity what really needs to be computed after compositing is updated.
- bool m_touchEventTargetRectsAreDirty;
-
private:
- void setTouchEventTargetRects(LayerHitTestRects&);
- void computeTouchEventTargetRects(LayerHitTestRects&);
-
blink::WebScrollbarLayer* addWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation, PassOwnPtr<blink::WebScrollbarLayer>);
blink::WebScrollbarLayer* getWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);
void removeWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);

Powered by Google App Engine
This is Rietveld 408576698