Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 713073003: remove updateTouchEventTargetRectsIfNeeded (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: moar Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayer.cpp
diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp
index be9337024d50b6a4bc1016b80eef8534e3bd580c..044a03a3069ecd9616398418a8429a3964585538 100644
--- a/sky/engine/core/rendering/RenderLayer.cpp
+++ b/sky/engine/core/rendering/RenderLayer.cpp
@@ -2672,44 +2672,6 @@ void RenderLayer::filterNeedsPaintInvalidation()
{
}
-void RenderLayer::addLayerHitTestRects(LayerHitTestRects& rects) const
-{
- computeSelfHitTestRects(rects);
- for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
- child->addLayerHitTestRects(rects);
-}
-
-void RenderLayer::computeSelfHitTestRects(LayerHitTestRects& rects) const
-{
- if (!size().isEmpty()) {
- Vector<LayoutRect> rect;
-
- if (renderBox() && renderBox()->scrollsOverflow()) {
- // For scrolling layers, rects are taken to be in the space of the contents.
- // We need to include the bounding box of the layer in the space of its parent
- // (eg. for border / scroll bars) and if it's composited then the entire contents
- // as well as they may be on another composited layer. Skip reporting contents
- // for non-composited layers as they'll get projected to the same layer as the
- // bounding box.
- if (compositingState() != NotComposited)
- rect.append(m_scrollableArea->overflowRect());
-
- rects.set(this, rect);
- if (const RenderLayer* parentLayer = parent()) {
- LayerHitTestRects::iterator iter = rects.find(parentLayer);
- if (iter == rects.end()) {
- rects.add(parentLayer, Vector<LayoutRect>()).storedValue->value.append(physicalBoundingBox(parentLayer));
- } else {
- iter->value.append(physicalBoundingBox(parentLayer));
- }
- }
- } else {
- rect.append(logicalBoundingBox());
- rects.set(this, rect);
- }
- }
-}
-
void RenderLayer::setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants()
{
renderer()->setShouldDoFullPaintInvalidation(true);

Powered by Google App Engine
This is Rietveld 408576698