Fix browser crash when parsing invalid Settings Override extension

Fix browser crash when parsing an Settings Override manifest with invalid URLs under 'chrome_settings_overrides.search_provider'.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235876

[vasilii, 2013-11-15 23:53:32]

Hi guys,

The crash was in settings_overrides_handler.cc:111. CreateManifestURL returned
NULL pointer if the search URL was broken.

Please review.

[not at google - send to devlin, 2013-11-16 00:38:30]

lgtm

https://codereview.chromium.org/71303009/diff/1/chrome/common/extensions/mani...
File
chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
(right):

https://codereview.chromium.org/71303009/diff/1/chrome/common/extensions/mani...
chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc:114:
&error);
EXPECT_EQ(that error you just added, error) ?

[vasilii, 2013-11-16 00:55:38]

https://codereview.chromium.org/71303009/diff/1/chrome/common/extensions/mani...
File
chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
(right):

https://codereview.chromium.org/71303009/diff/1/chrome/common/extensions/mani...
chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc:114:
&error);
On 2013/11/16 00:38:30, kalman wrote:
> EXPECT_EQ(that error you just added, error) ?

Done.

[commit-bot: I haz the power, 2013-11-18 18:09:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@chromium.org/71303009/160001

[commit-bot: I haz the power, 2013-11-18 19:14:05]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-18 23:05:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@chromium.org/71303009/500001

[commit-bot: I haz the power, 2013-11-19 01:34:54]

Change committed as 235876