Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 71303009: Fix browser crash when parsing invalid Settings Override extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed SettingsOverridePermissionTest.* Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
(...skipping 30 matching lines...) Expand all
41 startup_pages->AppendString("http://startup.com/startup.html"); 41 startup_pages->AppendString("http://startup.com/startup.html");
42 settings_override->Set("startup_pages", startup_pages.release()); 42 settings_override->Set("startup_pages", startup_pages.release());
43 } 43 }
44 if (flags & kSearchProvider) { 44 if (flags & kSearchProvider) {
45 scoped_ptr<DictionaryValue> search_provider(new DictionaryValue); 45 scoped_ptr<DictionaryValue> search_provider(new DictionaryValue);
46 search_provider->SetString("search_url", "http://google.com/search.html"); 46 search_provider->SetString("search_url", "http://google.com/search.html");
47 search_provider->SetString("name", "test"); 47 search_provider->SetString("name", "test");
48 search_provider->SetString("keyword", "lock"); 48 search_provider->SetString("keyword", "lock");
49 search_provider->SetString("encoding", "UTF-8"); 49 search_provider->SetString("encoding", "UTF-8");
50 search_provider->SetBoolean("is_default", true); 50 search_provider->SetBoolean("is_default", true);
51 search_provider->SetString("favicon_url", "wikipedia.org/wiki/Favicon"); 51 search_provider->SetString("favicon_url",
52 "http://wikipedia.org/wiki/Favicon");
52 settings_override->Set("search_provider", search_provider.release()); 53 settings_override->Set("search_provider", search_provider.release());
53 } 54 }
54 ext_manifest.Set( 55 ext_manifest.Set(
55 manifest_keys::kSettingsOverride, settings_override.release()); 56 manifest_keys::kSettingsOverride, settings_override.release());
56 57
57 Manifest manifest(&ext_manifest, "test"); 58 Manifest manifest(&ext_manifest, "test");
58 return LoadAndExpectSuccess(manifest); 59 return LoadAndExpectSuccess(manifest);
59 } 60 }
60 }; 61 };
61 62
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 129
129 130
130 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 131 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
131 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 132 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
132 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 133 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
133 } 134 }
134 135
135 } // namespace 136 } // namespace
136 137
137 } // namespace extensions 138 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698