extensions/common/manifest_constants.cc - Issue 71303009: Fix browser crash when parsing invalid Settings Override extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.cc

Issue 71303009: Fix browser crash when parsing invalid Settings Override extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed SettingsOverridePermissionTest.* Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_constants.cc

diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc

index 4f8236dfe12208b7f7b4cca50cc3b1e03f70c76a..1f28f94ffd384c14c199fca8ef43b3105b56a851 100644

--- a/extensions/common/manifest_constants.cc

+++ b/extensions/common/manifest_constants.cc

@@ -539,6 +539,8 @@ const char kInvalidSandboxedPagesCSP[] =

"Invalid value for 'sandbox.content_security_policy'.";

const char kInvalidScriptBadge[] =

"Invalid value for 'script_badge'.";

+const char kInvalidSearchEngineURL[] =

+ "Invalid URL [*] for 'chrome_settings_overrides.search_provider'.";

const char kInvalidEmptySettingsOverrides[] =

"Empty dictionary for 'chrome_settings_overrides'.";

const char kInvalidShortName[] =

« no previous file with comments | « extensions/common/manifest_constants.h ('k') | no next file » | no next file with comments »