chrome/common/extensions/permissions/settings_override_permission_unittest.cc - Issue 71303009: Fix browser crash when parsing invalid Settings Override extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 71303009: Fix browser crash when parsing invalid Settings Override extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed SettingsOverridePermissionTest.* Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

diff --git a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

index ad1dbf001c79d49a8989c019b646f69fc3040da0..4a2cc1689a824cbad74c87fa03dd3950390baa20 100644

--- a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

+++ b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

@@ -48,7 +48,8 @@ class SettingsOverridePermissionTest : public ExtensionManifestTest {

search_provider->SetString("keyword", "lock");

search_provider->SetString("encoding", "UTF-8");

search_provider->SetBoolean("is_default", true);

- search_provider->SetString("favicon_url", "wikipedia.org/wiki/Favicon");

+ search_provider->SetString("favicon_url",

+ "http://wikipedia.org/wiki/Favicon");

settings_override->Set("search_provider", search_provider.release());

}

ext_manifest.Set(