extensions/common/extension_messages.h - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.h

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/api/runtime.json ('K') | « extensions/common/api/runtime.json ('k') | extensions/renderer/messaging_bindings.cc » ('j') | extensions/renderer/resources/messaging.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_messages.h

diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h

index 45160b61360beffa7d41e0315bfac127f1e3e771..c76218a01d497c5bc04c3f5d08bba0544fe1749c 100644

--- a/extensions/common/extension_messages.h

+++ b/extensions/common/extension_messages.h

@@ -157,6 +157,10 @@ IPC_STRUCT_BEGIN(ExtensionMsg_ExternalConnectionInfo)

// wasn't initiated by an extension.

IPC_STRUCT_MEMBER(std::string, source_id)

+ // The ID of the frame that iniated the request. 0 if main frame, -1 if not

+ // initiated from a frame.

not at google - send to devlin 2014/11/10 18:36:42 0 if main frame, positive otherwise, or -1 if not

robwu 2014/11/10 21:43:07 Done.

+ IPC_STRUCT_MEMBER(int, source_frame_id)

// The URL of the frame that initiated the request.

IPC_STRUCT_MEMBER(GURL, source_url)

IPC_STRUCT_END()

« extensions/common/api/runtime.json ('K') | « extensions/common/api/runtime.json ('k') | extensions/renderer/messaging_bindings.cc » ('j') | extensions/renderer/resources/messaging.js » ('J')