extensions/renderer/messaging_bindings.cc - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/messaging_bindings.cc

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_messages.h ('K') | « extensions/common/extension_messages.h ('k') | extensions/renderer/resources/messaging.js » ('j') | extensions/renderer/resources/messaging.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/messaging_bindings.cc

diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc

index e7014fa895962a5fd09946c29bda777cb297d147..b9fcc22b094d0f9a88de8d8e090200be5abe82e5 100644

--- a/extensions/renderer/messaging_bindings.cc

+++ b/extensions/renderer/messaging_bindings.cc

@@ -282,6 +282,8 @@ void DispatchOnConnectToScriptContext(

channel_name.size()),

// sourceTab

tab,

+ // source_frame_id

+ v8::Integer::New(isolate, info.source_frame_id),

// sourceExtensionId

v8::String::NewFromUtf8(isolate,

info.source_id.c_str(),