Add frameId to MessageSender (extension messaging API)

extensions/renderer/resources/messaging.js

Index: extensions/renderer/resources/messaging.js
diff --git a/extensions/renderer/resources/messaging.js b/extensions/renderer/resources/messaging.js
index 5a83654c501357ad0b0a8c6578aa464076eb3fe8..ea34124f98761af4ef40742a55bbde1afb5968fc 100644
--- a/extensions/renderer/resources/messaging.js
+++ b/extensions/renderer/resources/messaging.js
@@ -216,6 +216,7 @@
   function dispatchOnConnect(portId,
                              channelName,
                              sourceTab,
+                             sourceFrameId,
                              sourceExtensionId,
                              targetExtensionId,
                              sourceUrl,
@@ -242,8 +243,10 @@
       sender.id = sourceExtensionId;
     if (sourceUrl)
       sender.url = sourceUrl;
-    if (sourceTab)
+    if (sourceTab) {
       sender.tab = sourceTab;
+      sender.frameId = sourceFrameId;
+    }

[not at google - send to devlin, 2014/11/10 18:36:42]

Minimise the amount of logic scattered about the place which decides whether or
not to set a frame ID, i.e. just make this logic "if (sourceFrameId >= 0)
sender.frameId = sourceFrameId;"

[robwu, 2014/11/10 21:43:07]

I've done this to make sure that frameId is only set if there is a tab. We need
to either set -1 here, OR set -1 in message_service.cc. Putting this check here
makes it immediately obvious that frameId can never be set if there is no tab.
Which do you prefer?

     if (tlsChannelId !== undefined)
       sender.tlsChannelId = tlsChannelId;