Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: extensions/common/extension_messages.h

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for extensions. 5 // IPC messages for extensions.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 // Struct containing the data for external connections to extensions. Used to 150 // Struct containing the data for external connections to extensions. Used to
151 // handle the IPCs initiated by both connect() and onConnect(). 151 // handle the IPCs initiated by both connect() and onConnect().
152 IPC_STRUCT_BEGIN(ExtensionMsg_ExternalConnectionInfo) 152 IPC_STRUCT_BEGIN(ExtensionMsg_ExternalConnectionInfo)
153 // The ID of the extension that is the target of the request. 153 // The ID of the extension that is the target of the request.
154 IPC_STRUCT_MEMBER(std::string, target_id) 154 IPC_STRUCT_MEMBER(std::string, target_id)
155 155
156 // The ID of the extension that initiated the request. May be empty if it 156 // The ID of the extension that initiated the request. May be empty if it
157 // wasn't initiated by an extension. 157 // wasn't initiated by an extension.
158 IPC_STRUCT_MEMBER(std::string, source_id) 158 IPC_STRUCT_MEMBER(std::string, source_id)
159 159
160 // The ID of the frame that iniated the request. 0 if main frame, -1 if not
161 // initiated from a frame.
not at google - send to devlin 2014/11/10 18:36:42 0 if main frame, positive otherwise, or -1 if not
robwu 2014/11/10 21:43:07 Done.
162 IPC_STRUCT_MEMBER(int, source_frame_id)
163
160 // The URL of the frame that initiated the request. 164 // The URL of the frame that initiated the request.
161 IPC_STRUCT_MEMBER(GURL, source_url) 165 IPC_STRUCT_MEMBER(GURL, source_url)
162 IPC_STRUCT_END() 166 IPC_STRUCT_END()
163 167
164 IPC_STRUCT_TRAITS_BEGIN(extensions::DraggableRegion) 168 IPC_STRUCT_TRAITS_BEGIN(extensions::DraggableRegion)
165 IPC_STRUCT_TRAITS_MEMBER(draggable) 169 IPC_STRUCT_TRAITS_MEMBER(draggable)
166 IPC_STRUCT_TRAITS_MEMBER(bounds) 170 IPC_STRUCT_TRAITS_MEMBER(bounds)
167 IPC_STRUCT_TRAITS_END() 171 IPC_STRUCT_TRAITS_END()
168 172
169 IPC_STRUCT_TRAITS_BEGIN(content::SocketPermissionRequest) 173 IPC_STRUCT_TRAITS_BEGIN(content::SocketPermissionRequest)
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 int /* acc_obj_id */, 778 int /* acc_obj_id */,
775 base::string16 /* selector */) 779 base::string16 /* selector */)
776 780
777 // Result of a query selector request. 781 // Result of a query selector request.
778 // result_acc_obj_id is the accessibility tree ID of the result element; 0 782 // result_acc_obj_id is the accessibility tree ID of the result element; 0
779 // indicates no result. 783 // indicates no result.
780 IPC_MESSAGE_ROUTED3(ExtensionHostMsg_AutomationQuerySelector_Result, 784 IPC_MESSAGE_ROUTED3(ExtensionHostMsg_AutomationQuerySelector_Result,
781 int /* request_id */, 785 int /* request_id */,
782 ExtensionHostMsg_AutomationQuerySelector_Error /* error */, 786 ExtensionHostMsg_AutomationQuerySelector_Error /* error */,
783 int /* result_acc_obj_id */) 787 int /* result_acc_obj_id */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698