Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 706903004: Revert of Add subscribeUniform extension pipeline (Closed)

Created:
6 years, 1 month ago by orglofch
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, kalyank, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add subscribeUniform extension pipeline (patchset #7 id:460001 of https://codereview.chromium.org/659903002/) Reason for revert: buildbot memory failure on Linux Tests Original issue's description: > Add subscribeUniform extension pipeline > > BUG=422978 > > Committed: https://crrev.com/80b40cc8eab5e6bef6221c0bc5c1d006059acd8f > Cr-Commit-Position: refs/heads/master@{#303050} TBR=kbr@chromium.org,bajones@chromium.org,piman@chromium.org,brianderson@chromium.org BUG=422978 Committed: https://crrev.com/1650e5447c7382948dc9659c39965489ed3af20a Cr-Commit-Position: refs/heads/master@{#303131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2131 lines) Patch
M gpu/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_subscribe_uniform.txt View 1 chunk +0 lines, -113 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +0 lines, -29 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +0 lines, -63 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +0 lines, -52 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +0 lines, -67 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 5 chunks +1 line, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 4 chunks +3 lines, -51 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +0 lines, -16 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +0 lines, -114 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +0 lines, -102 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +0 lines, -22 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +0 lines, -45 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +0 lines, -281 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +0 lines, -105 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +18 lines, -25 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 3 chunks +0 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 3 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 15 chunks +5 lines, -212 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +0 lines, -140 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +9 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 4 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
D gpu/command_buffer/service/gles2_cmd_decoder_unittest_valuebuffer.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 4 chunks +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
D gpu/command_buffer/service/valuebuffer_manager.h View 1 chunk +0 lines, -123 lines 0 comments Download
D gpu/command_buffer/service/valuebuffer_manager.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D gpu/command_buffer/service/valuebuffer_manager_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_impl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
orglofch
Created Revert of Add subscribeUniform extension pipeline
6 years, 1 month ago (2014-11-06 21:56:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706903004/1
6 years, 1 month ago (2014-11-06 21:57:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-06 21:57:28 UTC) #4
brianderson
lgtm
6 years, 1 month ago (2014-11-06 22:00:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706903004/1
6 years, 1 month ago (2014-11-06 22:02:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 00:07:26 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 00:08:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1650e5447c7382948dc9659c39965489ed3af20a
Cr-Commit-Position: refs/heads/master@{#303131}

Powered by Google App Engine
This is Rietveld 408576698