Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703563002: Remove shape-outside. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove shape-outside. Since we don't have floats this doesn't do anything now. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b6be0b2cab32dd6fa683cacde169e7ee5832956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2121 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -36 lines 0 comments Download
M sky/engine/core/animation/StringKeyframe.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -13 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +0 lines, -30 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 3 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +0 lines, -27 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 4 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/line/LineWidth.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/line/LineWidth.cpp View 2 chunks +0 lines, -39 lines 0 comments Download
D sky/engine/core/rendering/shapes/BoxShape.h View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/rendering/shapes/BoxShape.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
D sky/engine/core/rendering/shapes/BoxShapeTest.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
D sky/engine/core/rendering/shapes/PolygonShape.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/core/rendering/shapes/PolygonShape.cpp View 1 chunk +0 lines, -165 lines 0 comments Download
D sky/engine/core/rendering/shapes/RasterShape.h View 1 chunk +0 lines, -110 lines 0 comments Download
D sky/engine/core/rendering/shapes/RasterShape.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
D sky/engine/core/rendering/shapes/RectangleShape.h View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/engine/core/rendering/shapes/RectangleShape.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/engine/core/rendering/shapes/Shape.h View 1 chunk +0 lines, -104 lines 0 comments Download
D sky/engine/core/rendering/shapes/Shape.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
D sky/engine/core/rendering/shapes/ShapeInterval.h View 1 chunk +0 lines, -110 lines 0 comments Download
D sky/engine/core/rendering/shapes/ShapeOutsideInfo.h View 1 chunk +0 lines, -145 lines 0 comments Download
D sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 chunk +0 lines, -236 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 2 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
6 years, 1 month ago (2014-11-04 01:52:20 UTC) #1
ojan
lgtm
6 years, 1 month ago (2014-11-04 02:01:10 UTC) #2
esprehn
6 years, 1 month ago (2014-11-04 02:02:02 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8b6be0b2cab32dd6fa683cacde169e7ee5832956.

Powered by Google App Engine
This is Rietveld 408576698