Add MinidumpFileWriter::InitializeFromSnapshot() and its tests

Add MinidumpFileWriter::InitializeFromSnapshot() and its tests.

TEST=minidump_test MinidumpFileWriter.InitializeFromSnapshot*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/360e441c53ab4191a6fd2472cc57c3343a2f6944

[Mark Mentovai, 2014-11-07 00:22:01]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-11-07 00:22:01]

This depends on https://codereview.chromium.org/703353002/.

[Robert Sesek, 2014-11-07 17:07:48]

https://codereview.chromium.org/703223003/diff/1/minidump/minidump_file_write...
File minidump/minidump_file_writer.cc (right):

https://codereview.chromium.org/703223003/diff/1/minidump/minidump_file_write...
minidump/minidump_file_writer.cc:85:
exception->InitializeFromSnapshot(exception_snapshot, &thread_id_map);
The thread_id_map param here may be better passed as a const& (since it requires
the interface of MinidumpExceptionWriter to see that the pointer is const). This
is distinct from MinidumpThreadListWriter::InitializeFromSnapshot, which
actually populates the map.

https://codereview.chromium.org/703223003/diff/1/minidump/minidump_file_write...
File minidump/minidump_file_writer_test.cc (right):

https://codereview.chromium.org/703223003/diff/1/minidump/minidump_file_write...
minidump/minidump_file_writer_test.cc:265:
EXPECT_EQ(kMinidumpStreamTypeSystemInfo, directory[0].StreamType);
Is there any significance to the order in which the streams are added, since
you're checking that here?

https://codereview.chromium.org/703223003/diff/1/minidump/minidump_file_write...
minidump/minidump_file_writer_test.cc:365: // The module needs an annotation for
the MinidumpCrashpadInfo stream to be
May want to test a !IsUseful() module, too.

[Mark Mentovai, 2014-11-07 17:31:19]

Good feedback, thanks. Updated.

[Robert Sesek, 2014-11-07 19:18:05]

LGTM

[Mark Mentovai, 2014-11-07 19:47:15]

Committed patchset #2 (id:20001) manually as
360e441c53ab4191a6fd2472cc57c3343a2f6944 (presubmit successful).