minidump/minidump_exception_writer_test.cc - Issue 703223003: Add MinidumpFileWriter::InitializeFromSnapshot() and its tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_exception_writer_test.cc

Issue 703223003: Add MinidumpFileWriter::InitializeFromSnapshot() and its tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_crashpad_info_init_from_snapshot

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_exception_writer_test.cc

diff --git a/minidump/minidump_exception_writer_test.cc b/minidump/minidump_exception_writer_test.cc

index fa2f14d2d498a87c801eac29a9a693e50f3a270d..8c708c854abb6e25be830c80f7e0d97c2a699646 100644

--- a/minidump/minidump_exception_writer_test.cc

+++ b/minidump/minidump_exception_writer_test.cc

@@ -232,7 +232,7 @@ TEST(MinidumpExceptionWriter, InitializeFromSnapshot) {

thread_id_map[kThreadID] = expect_exception.ThreadId;

auto exception_writer = make_scoped_ptr(new MinidumpExceptionWriter());

- exception_writer->InitializeFromSnapshot(&exception_snapshot, &thread_id_map);

+ exception_writer->InitializeFromSnapshot(&exception_snapshot, thread_id_map);

MinidumpFileWriter minidump_file_writer;

minidump_file_writer.AddStream(exception_writer.Pass());

« no previous file with comments | « minidump/minidump_exception_writer.cc ('k') | minidump/minidump_file_writer.h » ('j') | no next file with comments »