Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: minidump/minidump_exception_writer.cc

Issue 703223003: Add MinidumpFileWriter::InitializeFromSnapshot() and its tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_crashpad_info_init_from_snapshot
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_exception_writer.h ('k') | minidump/minidump_exception_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_exception_writer.cc
diff --git a/minidump/minidump_exception_writer.cc b/minidump/minidump_exception_writer.cc
index b88f46aeffcff9937ea54a1f826d880c25def59e..87382b22d366ff8442fa38f0afa7bc30ded95502 100644
--- a/minidump/minidump_exception_writer.cc
+++ b/minidump/minidump_exception_writer.cc
@@ -32,12 +32,12 @@ MinidumpExceptionWriter::~MinidumpExceptionWriter() {
void MinidumpExceptionWriter::InitializeFromSnapshot(
const ExceptionSnapshot* exception_snapshot,
- const MinidumpThreadIDMap* thread_id_map) {
+ const MinidumpThreadIDMap& thread_id_map) {
DCHECK_EQ(state(), kStateMutable);
DCHECK(!context_);
- auto thread_id_it = thread_id_map->find(exception_snapshot->ThreadID());
- DCHECK(thread_id_it != thread_id_map->end());
+ auto thread_id_it = thread_id_map.find(exception_snapshot->ThreadID());
+ DCHECK(thread_id_it != thread_id_map.end());
SetThreadID(thread_id_it->second);
SetExceptionCode(exception_snapshot->Exception());
« no previous file with comments | « minidump/minidump_exception_writer.h ('k') | minidump/minidump_exception_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698